action_sheet: Add 'Channel feed' button to channel action sheet #1794
+222
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbobbe
added
the
integration review
gnprice
reviewed
Aug 14, 2025
test/widgets/action_sheet_test.dart
Outdated
Comment on lines
438
to
440
| testWidgets('from subscription list: visible ', (tester) async { | ||
| await prepare(); | ||
| await showFromInbox(tester); |
There was a problem hiding this comment.
Thanks for the catch!
test/widgets/action_sheet_test.dart
Outdated
| await tester.pump(); // [MenuItemButton.onPressed] called in a post-frame callback: flutter/flutter@e4a39fa2e | ||
| } | ||
|
|
||
| testWidgets('from inbox: visible ', (tester) async { |
There was a problem hiding this comment.
nit: stray space (here and others below)
Suggested change
| testWidgets('from inbox: visible ', (tester) async { | |
| testWidgets('from inbox: visible', (tester) async { |
chrisbobbe
force-pushed
the
pr-channel-feed-button-in-action-sheet
branch
from
1d89611 to
c47538c
Compare
|
Thanks, revision pushed! I've added one more commit, PTAL: c47538c topic_list: Don't show topic-list button in action sheet from app bar |
chrisbobbe
force-pushed
the
pr-channel-feed-button-in-action-sheet
branch
from
c47538c to
add8dc5
Compare
|
Ah pushed again to fix a failing test in that last commit. |
|
Thanks! Looks good; go ahead and merge once CI passes. |
…setup It looks like this param was only being used to avoid the topic-autocomplete behavior mentioned in the code comment. For invoking the channel action sheet by long-pressing the app bar, it shouldn't matter if the message list isn't showing any messages.
Similarly to how we don't show the "Channel feed" button when opening the same action sheet from a channel feed.
chrisbobbe
force-pushed
the
pr-channel-feed-button-in-action-sheet
branch
from
add8dc5 to
e12673a
Compare
|
Thanks! Done, after rebasing and running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1705.
Screenshots
From channel feed (no button)
Not from channel feed (button)